hubcio commented on code in PR #4608:
URL: https://github.com/apache/iggy/pull/4608#discussion_r4471674776
##########
core/ai/mcp/src/service/mod.rs:
##########
@@ -586,7 +583,7 @@ impl IggyService {
offset,
}): Parameters<StoreConsumerOffset>,
) -> Result<CallToolResult, ErrorData> {
- self.permissions.ensure_update()?;
+ self.permissions.ensure_read()?;
Review Comment:
critical: `read` permits offset writes but still denies their recovery, so
an uncertain store/delete blocks later offset writes and `next` polls on that
partition. allow recovery of these offset operations and update the permission
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
