This is an automated email from the ASF dual-hosted git repository.
csringhofer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 322515c44 IMPALA-14710: (addendum) Fixed flaky test in
TestReduceExprShuttle
322515c44 is described below
commit 322515c44b15522f05dc2f6a71ce8d1407bf3e03
Author: Steve Carlin <[email protected]>
AuthorDate: Tue Feb 3 09:22:25 2026 -0800
IMPALA-14710: (addendum) Fixed flaky test in TestReduceExprShuttle
The previous fix still had race condition issues due to the order
of static initialization. Putting the property value in the pom.xml
file should fix this issue.
Change-Id: I33baebaf5d678d437f7381d774c50de4f25f8431
Reviewed-on: http://gerrit.cloudera.org:8080/23934
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
java/calcite-planner/pom.xml | 3 +++
.../test/java/org/apache/impala/planner/TestReduceExprShuttle.java | 6 ------
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/java/calcite-planner/pom.xml b/java/calcite-planner/pom.xml
index eca41b271..57ab438c7 100644
--- a/java/calcite-planner/pom.xml
+++ b/java/calcite-planner/pom.xml
@@ -225,6 +225,9 @@ under the License.
<additionalClasspathElements>
<additionalClasspathElement>${env.IMPALA_HOME}/fe/src/test/resources</additionalClasspathElement>
</additionalClasspathElements>
+ <systemPropertyVariables>
+ <calcite.default.charset>UTF8</calcite.default.charset>
+ </systemPropertyVariables>
</configuration>
</plugin>
</plugins>
diff --git
a/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java
b/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java
index a60eb40f5..554740553 100644
---
a/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java
+++
b/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java
@@ -64,12 +64,6 @@ import static org.junit.Assert.*;
public class TestReduceExprShuttle extends PlannerTestBase {
- // This code is duplicated in CalciteCompilerFactory, but it is needed
- // here because that class is not imported in this test.
- static {
- System.setProperty("calcite.default.charset", "UTF8");
- }
-
// Query option to run each planner test.
private static TQueryOptions options =
tpcdsParquetQueryOptions();
