This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new f6363ce03 IMPALA-14722: Switch default for PREPOPULATE_M2_REPOSITORY
to false
f6363ce03 is described below
commit f6363ce03d45c29da3428d9b6c4d878cbd37d15e
Author: Joe McDonnell <[email protected]>
AuthorDate: Wed Feb 4 13:50:31 2026 -0800
IMPALA-14722: Switch default for PREPOPULATE_M2_REPOSITORY to false
Upstream Jenkins switches to requiring a login. This broke the
functionality for bin/jenkins/populate_m2_directory.py. Some
precommit jobs have been seeing unexplained 30+ minute gaps
in time. Setting PREPOPULATE_M2_REPOSITORY=false seems to avoid
this. It is possible that bin/jenkins/populate_m2_directory.py
fails quickly in most cases but can hang for a longer time
intermittently.
This changes bin/bootstrap_build.sh to use code identical to
bin/bootstrap_system.sh (i.e. controlled by
PREPOPULATE_M2_REPOSITORY). It sets the default value for
PREPOPULATE_M2_REPOSITORY to false in both scripts.
In future, we may remove this code entirely.
Testing:
- Ran precommit job
Change-Id: Ie338f528f4861d885e484136689a6a5c72b57c70
Reviewed-on: http://gerrit.cloudera.org:8080/23940
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
---
bin/bootstrap_build.sh | 12 +++++++++---
bin/bootstrap_system.sh | 5 +++--
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/bin/bootstrap_build.sh b/bin/bootstrap_build.sh
index 2dde710bd..ea81e4439 100755
--- a/bin/bootstrap_build.sh
+++ b/bin/bootstrap_build.sh
@@ -85,9 +85,15 @@ if [ ! -d "/usr/local/apache-maven-${MVN_VERSION}" ]; then
sudo ln -s /usr/local/apache-maven-${MVN_VERSION}/bin/mvn /usr/local/bin
fi
-# Try to prepopulate the m2 directory to save time
-if ! bin/jenkins/populate_m2_directory.py ; then
- echo "Failed to prepopulate the m2 directory. Continuing..."
+# Optionally try to prepopulate the m2 directory to save time. Since Maven has
+# improved download parallelism, this now defaults to false.
+if [[ "${PREPOPULATE_M2_REPOSITORY:-false}" == true ]] ; then
+ echo ">>> Populating m2 directory..."
+ if ! bin/jenkins/populate_m2_directory.py ; then
+ echo "Failed to prepopulate the m2 directory. Continuing..."
+ fi
+else
+ echo ">>> Skip populating m2 directory"
fi
./buildall.sh -notests -so
diff --git a/bin/bootstrap_system.sh b/bin/bootstrap_system.sh
index 65d1fb78d..9ee10a2e8 100755
--- a/bin/bootstrap_system.sh
+++ b/bin/bootstrap_system.sh
@@ -565,8 +565,9 @@ SET_IMPALA_HOME="export IMPALA_HOME=$(pwd)"
echo -e "\n$SET_IMPALA_HOME" >> ~/.bashrc
eval "$SET_IMPALA_HOME"
-# Try to prepopulate the m2 directory to save time
-if [[ "${PREPOPULATE_M2_REPOSITORY:-true}" == true ]] ; then
+# Optionally try to prepopulate the m2 directory to save time. Since Maven has
+# improved download parallelism, this now defaults to false.
+if [[ "${PREPOPULATE_M2_REPOSITORY:-false}" == true ]] ; then
echo ">>> Populating m2 directory..."
if ! bin/jenkins/populate_m2_directory.py ; then
echo "Failed to prepopulate the m2 directory. Continuing..."
