Repository: incubator-impala Updated Branches: refs/heads/master 547be27e7 -> 2100b3a34
IMPALA-3587: Get rid of not_default_fs skip marker The SkipIf.not_default_fs used in test_compute_stats(), was meant to skip non-HDFS filesystems. However, since we've changed our test infrastructure to run with S3 and Isilion as default Filesystems, this test has been working just fine and this skip marker has had no effect. I've also confirmed that this works on localFS. Change-Id: I7776ad60ce0298d08b20c2573894463bdfb9f892 Reviewed-on: http://gerrit.cloudera.org:8080/3382 Reviewed-by: Sailesh Mukil <[email protected]> Tested-by: Sailesh Mukil <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/a6198ce8 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/a6198ce8 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/a6198ce8 Branch: refs/heads/master Commit: a6198ce8a48ea59162389cc9fb3cd1a0aa6096d3 Parents: 547be27 Author: Sailesh Mukil <[email protected]> Authored: Mon Jun 13 16:50:12 2016 -0700 Committer: Tim Armstrong <[email protected]> Committed: Thu Jun 16 00:34:13 2016 -0700 ---------------------------------------------------------------------- tests/common/skip.py | 2 -- tests/metadata/test_compute_stats.py | 2 -- tests/metadata/test_ddl.py | 1 - 3 files changed, 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/a6198ce8/tests/common/skip.py ---------------------------------------------------------------------- diff --git a/tests/common/skip.py b/tests/common/skip.py index e434915..ab95904 100644 --- a/tests/common/skip.py +++ b/tests/common/skip.py @@ -47,8 +47,6 @@ class SkipIfS3: class SkipIf: skip_hbase = pytest.mark.skipif(pytest.config.option.skip_hbase, reason="--skip_hbase argument specified") - not_default_fs = pytest.mark.skipif(not IS_DEFAULT_FS, - reason="Default filesystem needed") kudu_not_supported = pytest.mark.skipif(os.environ["KUDU_IS_SUPPORTED"] == "false", reason="Kudu is not supported") not_s3 = pytest.mark.skipif(not IS_S3, reason="S3 Filesystem needed") http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/a6198ce8/tests/metadata/test_compute_stats.py ---------------------------------------------------------------------- diff --git a/tests/metadata/test_compute_stats.py b/tests/metadata/test_compute_stats.py index 925fce2..efd8c4e 100644 --- a/tests/metadata/test_compute_stats.py +++ b/tests/metadata/test_compute_stats.py @@ -21,7 +21,6 @@ from tests.common.skip import SkipIfS3, SkipIfIsilon, SkipIf, SkipIfLocal from tests.util.filesystem_utils import WAREHOUSE # Tests the COMPUTE STATS command for gathering table and column stats. [email protected]_default_fs # Isilon: Missing coverage: compute stats class TestComputeStats(ImpalaTestSuite): @classmethod def get_workload(self): @@ -134,7 +133,6 @@ class TestHbaseComputeStats(ImpalaTestSuite): unique_database) [email protected]_default_fs # Isilon: Missing coverage: compute stats class TestCorruptTableStats(ImpalaTestSuite): @classmethod def get_workload(self): http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/a6198ce8/tests/metadata/test_ddl.py ---------------------------------------------------------------------- diff --git a/tests/metadata/test_ddl.py b/tests/metadata/test_ddl.py index f1d85c6..d4c99a2 100644 --- a/tests/metadata/test_ddl.py +++ b/tests/metadata/test_ddl.py @@ -279,7 +279,6 @@ class TestDdlStatements(TestDdlBase): self.filesystem_client.delete_file_dir('test-warehouse/%s' % dir_, recursive=True) @pytest.mark.execute_serially - @SkipIf.not_default_fs def test_alter_set_column_stats(self, vector): self._create_db('alter_table_test_db', sync=True) self.run_test_case('QueryTest/alter-table-set-column-stats',
