IMPALA-3751: fix clang build errors and warnings Fix misc clang errors and warnings.
Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973 Reviewed-on: http://gerrit.cloudera.org:8080/3391 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Internal Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/2100b3a3 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/2100b3a3 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/2100b3a3 Branch: refs/heads/master Commit: 2100b3a346d760d9e0c3fe450ec2fe74d254a38d Parents: a6198ce Author: Tim Armstrong <[email protected]> Authored: Wed Jun 15 16:53:31 2016 -0700 Committer: Tim Armstrong <[email protected]> Committed: Thu Jun 16 00:34:14 2016 -0700 ---------------------------------------------------------------------- be/src/exec/hdfs-avro-scanner-test.cc | 5 ++--- be/src/exec/zigzag-test.cc | 8 ++++---- be/src/udf/uda-test.cc | 2 +- 3 files changed, 7 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/2100b3a3/be/src/exec/hdfs-avro-scanner-test.cc ---------------------------------------------------------------------- diff --git a/be/src/exec/hdfs-avro-scanner-test.cc b/be/src/exec/hdfs-avro-scanner-test.cc index 1a8b759..1f5a49e 100644 --- a/be/src/exec/hdfs-avro-scanner-test.cc +++ b/be/src/exec/hdfs-avro-scanner-test.cc @@ -442,9 +442,8 @@ TEST_F(HdfsAvroScannerTest, DecimalTest) { TestReadAvroDecimal(data, 1, d16v, -1, TErrorCode::AVRO_TRUNCATED_BLOCK); TestReadAvroDecimal(data, 4, d16v, -1, TErrorCode::AVRO_TRUNCATED_BLOCK); - bool overflow; - d16v = Decimal16Value::FromDouble(38, 0, .1e38d, &overflow); - DCHECK(!overflow); + /// Produce a very large decimal value. + memset(&d16v.value(), 0xFF, sizeof(d16v.value())); data[0] = 32; // decodes to 16 #if __BYTE_ORDER == __LITTLE_ENDIAN BitUtil::ByteSwap(&data[1], &d16v.value(), 16); http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/2100b3a3/be/src/exec/zigzag-test.cc ---------------------------------------------------------------------- diff --git a/be/src/exec/zigzag-test.cc b/be/src/exec/zigzag-test.cc index 247510f..12db954 100644 --- a/be/src/exec/zigzag-test.cc +++ b/be/src/exec/zigzag-test.cc @@ -107,15 +107,15 @@ TEST(ZigzagTest, Errors) { // Test 100-byte int uint8_t* buf_ptr = static_cast<uint8_t*>(buf); int64_t buf_len = sizeof(buf); - EXPECT_TRUE(ReadWriteUtil::ReadZLong(&buf_ptr, buf + buf_len).error); - EXPECT_TRUE(ReadWriteUtil::ReadZInt(&buf_ptr, buf + buf_len).error); + EXPECT_FALSE(ReadWriteUtil::ReadZLong(&buf_ptr, buf + buf_len).ok); + EXPECT_FALSE(ReadWriteUtil::ReadZInt(&buf_ptr, buf + buf_len).ok); // Test truncated int buf_ptr = static_cast<uint8_t*>(buf); buf_len = ReadWriteUtil::MAX_ZLONG_LEN - 1; - EXPECT_TRUE(ReadWriteUtil::ReadZLong(&buf_ptr, buf + buf_len).error); + EXPECT_FALSE(ReadWriteUtil::ReadZLong(&buf_ptr, buf + buf_len).ok); buf_len = ReadWriteUtil::MAX_ZINT_LEN - 1; - EXPECT_TRUE(ReadWriteUtil::ReadZInt(&buf_ptr, buf + buf_len).error); + EXPECT_FALSE(ReadWriteUtil::ReadZInt(&buf_ptr, buf + buf_len).ok); } // Test weird encodings and values that are arguably invalid but we still accept http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/2100b3a3/be/src/udf/uda-test.cc ---------------------------------------------------------------------- diff --git a/be/src/udf/uda-test.cc b/be/src/udf/uda-test.cc index 62965d2..82250e9 100644 --- a/be/src/udf/uda-test.cc +++ b/be/src/udf/uda-test.cc @@ -250,7 +250,7 @@ TEST(CountMultiArgTest, Basic) { bool FuzzyCompare(const BigIntVal& r1, const BigIntVal& r2) { if (r1.is_null && r2.is_null) return true; if (r1.is_null || r2.is_null) return false; - return abs(r1.val - r2.val) <= 1; + return std::abs(r1.val - r2.val) <= 1; } TEST(CountTest, FuzzyEquals) {
