gosonzhang commented on code in PR #5225:
URL: https://github.com/apache/inlong/pull/5225#discussion_r934248315
##########
inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/broker/web/AbstractWebHandler.java:
##########
@@ -61,15 +63,14 @@ protected void doPost(HttpServletRequest req,
WebApiRegInfo webApiRegInfo = getWebApiRegInfo(method);
if (webApiRegInfo == null) {
sBuffer.append("{\"result\":false,\"errCode\":400,\"errMsg\":\"")
- .append("Unsupported method
").append(method).append("\"}");
+ .append("Unsupported method ").append("\"}");
} else {
webApiRegInfo.method.invoke(webApiRegInfo.webHandler, req,
sBuffer);
}
}
} catch (Throwable e) {
sBuffer.append("{\"result\":false,\"errCode\":400,\"errMsg\":\"")
- .append("Bad request from server: ")
- .append(e.getMessage())
+ .append("Bad request from server. ")
Review Comment:
This cannot be removed, it is used to locate the problem
##########
inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/broker/web/AbstractWebHandler.java:
##########
@@ -61,15 +63,14 @@ protected void doPost(HttpServletRequest req,
WebApiRegInfo webApiRegInfo = getWebApiRegInfo(method);
if (webApiRegInfo == null) {
sBuffer.append("{\"result\":false,\"errCode\":400,\"errMsg\":\"")
- .append("Unsupported method
").append(method).append("\"}");
+ .append("Unsupported method ").append("\"}");
Review Comment:
This cannot be removed, it is used to locate the problem
##########
inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/master/web/MasterStatusCheckFilter.java:
##########
@@ -47,8 +52,8 @@ public void init(FilterConfig filterConfig) throws
ServletException {
@Override
public void doFilter(ServletRequest request,
Review Comment:
This place needs to stay the same
The address provided by the Master when redirecting is a limited set, and it
is internal access, so it has little impact if it is not checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
