gosonzhang commented on code in PR #5225:
URL: https://github.com/apache/inlong/pull/5225#discussion_r935055069
##########
inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/broker/web/AbstractWebHandler.java:
##########
@@ -83,8 +85,8 @@ protected void doPost(HttpServletRequest req,
public abstract void registerWebApiMethod();
protected void innRegisterWebMethod(String webMethodName,
- String clsMethodName,
Review Comment:
It is recommended not to modify this code style: it adopts the parameter up
and down alignment mode; if it is modified according to the submitted mode, the
style in this module will be inconsistent, which makes people feel very messy.
##########
inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/master/web/MasterStatusCheckFilter.java:
##########
@@ -39,6 +40,7 @@ public MasterStatusCheckFilter(TMaster master) {
this.master = master;
this.defMetaDataService =
this.master.getMetaDataService();
+
Review Comment:
It is recommended not to modify this code style: it adopts the parameter up
and down alignment mode; if it is modified according to the submitted mode, the
style in this module will be inconsistent, which makes people feel very messy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
