gong commented on code in PR #5906:
URL: https://github.com/apache/inlong/pull/5906#discussion_r973995570
##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/SinkMetricData.java:
##########
@@ -286,16 +286,17 @@ public void invokeDirty(long rowCount, long rowSize) {
@Override
public String toString() {
return "SinkMetricData{"
- + "groupId='" + groupId + '\''
- + ", streamId='" + streamId + '\''
- + ", nodeId='" + nodeId + '\''
- + ", numRecordsOut=" + numRecordsOut.getCount()
- + ", numBytesOut=" + numBytesOut.getCount()
- + ", numRecordsOutForMeter=" + numRecordsOutForMeter.getCount()
- + ", numBytesOutForMeter=" + numBytesOutForMeter.getCount()
- + ", dirtyRecords=" + dirtyRecords.getCount()
- + ", dirtyBytes=" + dirtyBytes.getCount()
- + ", numRecordsOutPerSecond=" +
numRecordsOutPerSecond.getRate()
- + ", numBytesOutPerSecond=" + numBytesOutPerSecond.getRate()
+ + "metricGroup=" + metricGroup
+ + ", labels=" + labels
+ + ", auditImp=" + auditImp
+ + ", numRecordsOut=" + numRecordsOut
+ + ", numBytesOut=" + numBytesOut
+ + ", numRecordsOutForMeter=" + numRecordsOutForMeter
+ + ", numBytesOutForMeter=" + numBytesOutForMeter
+ + ", dirtyRecords=" + dirtyRecords
+ + ", dirtyBytes=" + dirtyBytes
+ + ", numRecordsOutPerSecond=" + numRecordsOutPerSecond
+ + ", numBytesOutPerSecond=" + numBytesOutPerSecond
Review Comment:
Counter and Meter don't override toString(). So this print info is not
useful. It need print getCount() and getRate().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
