Oneal65 commented on code in PR #5906:
URL: https://github.com/apache/inlong/pull/5906#discussion_r972704659
##########
inlong-sort/sort-connectors/elasticsearch-base/src/main/java/org/apache/inlong/sort/elasticsearch/table/RowElasticsearchSinkFunction.java:
##########
@@ -94,44 +85,20 @@ public RowElasticsearchSinkFunction(
public void open(RuntimeContext ctx) {
indexGenerator.open();
this.runtimeContext = ctx;
- if (inlongMetric != null && !inlongMetric.isEmpty()) {
- String[] inlongMetricArray = inlongMetric.split(DELIMITER);
- groupId = inlongMetricArray[0];
- streamId = inlongMetricArray[1];
- String nodeId = inlongMetricArray[2];
- sinkMetricData = new SinkMetricData(groupId, streamId, nodeId,
runtimeContext.getMetricGroup());
- sinkMetricData.registerMetricsForNumBytesOut();
- sinkMetricData.registerMetricsForNumRecordsOut();
- sinkMetricData.registerMetricsForNumBytesOutPerSecond();
- sinkMetricData.registerMetricsForNumRecordsOutPerSecond();
- }
-
- if (auditHostAndPorts != null) {
- AuditImp.getInstance().setAuditProxy(new
HashSet<>(Arrays.asList(auditHostAndPorts.split(DELIMITER))));
- auditImp = AuditImp.getInstance();
- }
- }
-
- private void outputMetricForAudit(long size) {
- if (auditImp != null) {
- auditImp.add(
- Constants.AUDIT_SORT_OUTPUT,
- groupId,
- streamId,
- System.currentTimeMillis(),
- 1,
- size);
+ MetricOption metricOption = MetricOption.builder()
+ .withInlongGroupStreamNode(inlongMetric)
+ .withInlongAudit(auditHostAndPorts)
+ .withRegisterMetric(RegisteredMetric.ALL)
Review Comment:
should not register DirtyBytes and DirtyRecords
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
