chestnut-c commented on code in PR #6585: URL: https://github.com/apache/inlong/pull/6585#discussion_r1030435173
########## inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/MetricType.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sort.base; + +/** + * connector metric type enum + */ +public enum MetricType { Review Comment: > It seems unnecessary to define the metric type, just extend it on the option 'inlong.metric.label'. This enumeration is to distinguish Node indicators or more fine-grained indicators. Fine-grained indicators are currently expanded on the main node indicators. The purpose of adding enumeration is to facilitate maintenance, if not needed also ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
