yunqingmoswu commented on PR #6585:
URL: https://github.com/apache/inlong/pull/6585#issuecomment-1328491853
> > It is recommended to extend the option 'inlong.metric.labels' instead of
adding metric type. For example you can format as
'groupId=xxx&streamId=xxx&nodeId=xxx&database=${database}&table=${table}', in
this format the '${xxx}' represents a variable, and the specific supported
variables are determined by the connector.
>
> > 'inlong.metric.labels'
>
> If you use what you said to do it, it feels a bit redundant. First of all,
you can’t directly get the label at the node level, unless you add
'inlong.metric.tableLabels'. It is better to hand over the specific sub-label
to the specific connector.
Normally, it should be like this. The reporting of indicators based on
nodeId is closed, so it is a closed loop inside sort, but this function has
broken this agreement and is open. Then, general rules should be defined, and
each connector can implement it according to the situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
