gosonzhang commented on code in PR #7170:
URL: https://github.com/apache/inlong/pull/7170#discussion_r1063055036
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/openapi/OpenDataNodeController.java:
##########
@@ -71,24 +70,21 @@ public Response<List<DataNodeInfo>> list(@RequestBody
DataNodePageRequest reques
@PostMapping(value = "/node/save")
@ApiOperation(value = "Save node")
@OperationLog(operation = OperationType.CREATE)
- @RequiresRoles(value = UserRoleCode.ADMIN)
- public Response<Integer> save(@Validated @RequestBody DataNodeRequest
request) {
+ public Response<Integer> save(@Validated(SaveValidation.class)
@RequestBody DataNodeRequest request) {
return Response.success(dataNodeService.save(request,
LoginUserUtils.getLoginUser()));
}
@PostMapping(value = "/node/update")
- @OperationLog(operation = OperationType.UPDATE)
@ApiOperation(value = "Update data node")
- @RequiresRoles(value = UserRoleCode.ADMIN)
Review Comment:
The role check is performed in the open api, and this will be strengthened
in the future to make it more detailed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
