gosonzhang commented on code in PR #7170:
URL: https://github.com/apache/inlong/pull/7170#discussion_r1063055732
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/es/ElasticsearchDataNodeDTO.java:
##########
@@ -85,8 +85,8 @@ public static ElasticsearchDataNodeDTO getFromJson(@NotNull
String extParams) {
try {
return JsonUtils.parseObject(extParams,
ElasticsearchDataNodeDTO.class);
} catch (Exception e) {
- LOGGER.error("Failed to extract additional parameters for
Elasticsearch data node: ", e);
Review Comment:
API calls will be more frequent. If every request is logged, the manager
node will explode due to too much log output
Then the exception of this block is the json encoding and decoding operation
of the extParams content. If it fails, the caller will provide the specific
content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
