gong commented on code in PR #7716:
URL: https://github.com/apache/inlong/pull/7716#discussion_r1150294892
##########
inlong-sort/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/DynamicSchemaHandleOperator.java:
##########
@@ -252,7 +265,7 @@ private void handleDirtyData(Object dirtyData,
dirtySinkHelper.invoke(dirtyData, dirtyType,
dirtyOptions.getLabels(), dirtyOptions.getLogTag(),
dirtyOptions.getIdentifier(), e);
}
- if (metricData != null) {
+ if (metricData != null && needDirtyMetric) {
metricData.outputDirtyMetricsWithEstimate(tableId.namespace().toString(), null,
tableId.name(), dirtyData);
Review Comment:
Why not remove
`metricData.outputDirtyMetricsWithEstimate(tableId.namespace().toString(),
null, tableId.name(), dirtyData);`. DynamicSchemaHandleOperator pass dirty data
metrics by RecordWithSchema.
And
`metricData.outputDirtyMetricsWithEstimate(tableId.namespace().toString(),
null, tableId.name(), dirtyData)` also is error ref to
IcebergMultipleStreamWriter.java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
