e-mhui opened a new pull request, #8131:
URL: https://github.com/apache/inlong/pull/8131
### Prepare a Pull Request
[INLONG-8125][Sort] Optimizing the speed of transitioning from snapshot to
binlog
- Fixes #8125
### Motivation
When transitioning from the snapshot phase to the binlog phase, the
`shouldEmit()` method is called. Its function is to traverse all splits for
each Binlog data and check whether the record is located after the end of the
snapshot phase. However, the time complexity of this method is O(n). Since
finishedSplitsInfo is locally ordered, we can use binary search to find the
split where the current binlog is located, reducing the time complexity from
`O(n)` to `O(logn)`.
### Modifications
Use binary search to find the split which contain the specific key.
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up
issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
