e-mhui commented on code in PR #8131:
URL: https://github.com/apache/inlong/pull/8131#discussion_r1217594670
##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/mysql-cdc/src/main/java/org/apache/inlong/sort/cdc/mysql/debezium/reader/BinlogSplitReader.java:
##########
@@ -204,6 +205,12 @@ private boolean shouldEmit(SourceRecord sourceRecord) {
splitKeyType,
sourceRecord,
statefulTaskContext.getSchemaNameAdjuster());
+ // currently, we only support using binary search algorithm
for a single split key.
+ if (key.length == 1) {
+ FinishedSnapshotSplitInfo splitInfo =
getSplitInfoByBinarySearch(
+ finishedSplitsInfo.get(tableId), key);
Review Comment:
#8044 adjusts the order of assigning `SnapshotSplits`. After all the
`SnapshotSplits` are read, the `FinishedSnapshotSplitInfos` will be sent to
`MySqlBinlogSplit`. This PR adjusts the order of `FinishedSnapshotSplitInfos`
in MySqlBinlogSplit, so the previous PR #8044 will not affect this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
