EMsnap commented on code in PR #8141: URL: https://github.com/apache/inlong/pull/8141#discussion_r1214126192
########## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/schema/IcebergSchemaChangeHelper.java: ########## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sort.iceberg.schema; + +import org.apache.inlong.sort.base.dirty.DirtySinkHelper; +import org.apache.inlong.sort.base.dirty.DirtyType; +import org.apache.inlong.sort.base.format.JsonDynamicSchemaFormat; +import org.apache.inlong.sort.base.metric.sub.SinkTableMetricData; +import org.apache.inlong.sort.base.schema.SchemaChangeHandleException; +import org.apache.inlong.sort.base.schema.SchemaChangeHelper; +import org.apache.inlong.sort.base.sink.SchemaUpdateExceptionPolicy; +import org.apache.inlong.sort.iceberg.sink.multiple.IcebergSchemaChangeUtils; +import org.apache.inlong.sort.protocol.ddl.enums.PositionType; +import org.apache.inlong.sort.protocol.ddl.expressions.AlterColumn; +import org.apache.inlong.sort.protocol.ddl.expressions.Column; +import org.apache.inlong.sort.protocol.ddl.operations.CreateTableOperation; +import org.apache.inlong.sort.protocol.enums.SchemaChangePolicy; +import org.apache.inlong.sort.protocol.enums.SchemaChangeType; +import org.apache.inlong.sort.schema.TableChange; + +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.JsonNode; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.RowType; +import org.apache.iceberg.Schema; +import org.apache.iceberg.Table; +import org.apache.iceberg.Transaction; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.catalog.SupportsNamespaces; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.flink.FlinkSchemaUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; + +/** + * Iceberg schema change helper + * */ +public class IcebergSchemaChangeHelper extends SchemaChangeHelper { + + private static final Logger LOGGER = LoggerFactory.getLogger(IcebergSchemaChangeHelper.class); + private transient Catalog catalog; + + private transient SupportsNamespaces asNamespaceCatalog; + + public IcebergSchemaChangeHelper(JsonDynamicSchemaFormat dynamicSchemaFormat, boolean schemaChange, + Map<SchemaChangeType, SchemaChangePolicy> policyMap, String databasePattern, String tablePattern, + SchemaUpdateExceptionPolicy exceptionPolicy, + SinkTableMetricData metricData, DirtySinkHelper<Object> dirtySinkHelper, + Catalog catalog, + SupportsNamespaces asNamespaceCatalog) { + super(dynamicSchemaFormat, schemaChange, policyMap, databasePattern, + tablePattern, exceptionPolicy, metricData, dirtySinkHelper); + this.catalog = catalog; + this.asNamespaceCatalog = asNamespaceCatalog; + } + @Override + public void doAlterOperation(String database, String table, byte[] originData, String originSchema, JsonNode data, + Map<SchemaChangeType, List<AlterColumn>> typeMap) { + for (Map.Entry<SchemaChangeType, List<AlterColumn>> kv : typeMap.entrySet()) { + SchemaChangePolicy policy = policyMap.get(kv.getKey()); + doSchemaChangeBase(kv.getKey(), policy, originSchema); + if (policy == SchemaChangePolicy.ENABLE) { + try { + switch (kv.getKey()) { + case ADD_COLUMN: + doAddColumn(kv.getValue(), TableIdentifier.of(database, table)); + break; + case DROP_COLUMN: + doDropColumn(kv.getKey(), originSchema); + break; + case RENAME_COLUMN: + doRenameColumn(kv.getKey(), originSchema); + break; + case CHANGE_COLUMN_TYPE: + doChangeColumnType(kv.getKey(), originSchema); Review Comment: doSchemaChangeBase is called before and also inside doChangeColumnType, why is that and any way to improve this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
