gong commented on code in PR #8141: URL: https://github.com/apache/inlong/pull/8141#discussion_r1214151382
########## inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/schema/SchemaChangeHelper.java: ########## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.sort.base.schema; + +import org.apache.inlong.sort.base.dirty.DirtySinkHelper; +import org.apache.inlong.sort.base.dirty.DirtyType; +import org.apache.inlong.sort.base.format.JsonDynamicSchemaFormat; +import org.apache.inlong.sort.base.metric.sub.SinkTableMetricData; +import org.apache.inlong.sort.base.sink.SchemaUpdateExceptionPolicy; +import org.apache.inlong.sort.protocol.ddl.expressions.AlterColumn; +import org.apache.inlong.sort.protocol.ddl.operations.AlterOperation; +import org.apache.inlong.sort.protocol.ddl.operations.CreateTableOperation; +import org.apache.inlong.sort.protocol.ddl.operations.Operation; +import org.apache.inlong.sort.protocol.enums.SchemaChangePolicy; +import org.apache.inlong.sort.protocol.enums.SchemaChangeType; +import org.apache.inlong.sort.util.SchemaChangeUtils; + +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.type.TypeReference; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.JsonNode; +import org.apache.flink.util.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; + +/** + * Schema change helper + * */ +public abstract class SchemaChangeHelper implements SchemaChangeHandle { + + private static final Logger LOGGER = LoggerFactory.getLogger(SchemaChangeHelper.class); + private final boolean schemaChange; + protected final Map<SchemaChangeType, SchemaChangePolicy> policyMap; + protected final JsonDynamicSchemaFormat dynamicSchemaFormat; + private final String databasePattern; + private final String tablePattern; + protected final SchemaUpdateExceptionPolicy exceptionPolicy; + private final SinkTableMetricData metricData; + private final DirtySinkHelper<Object> dirtySinkHelper; + + public SchemaChangeHelper(JsonDynamicSchemaFormat dynamicSchemaFormat, boolean schemaChange, + Map<SchemaChangeType, SchemaChangePolicy> policyMap, String databasePattern, String tablePattern, + SchemaUpdateExceptionPolicy exceptionPolicy, + SinkTableMetricData metricData, DirtySinkHelper<Object> dirtySinkHelper) { + this.dynamicSchemaFormat = Preconditions.checkNotNull(dynamicSchemaFormat, "dynamicSchemaFormat is null"); + this.schemaChange = schemaChange; + this.policyMap = policyMap; + this.databasePattern = databasePattern; + this.tablePattern = tablePattern; + this.exceptionPolicy = exceptionPolicy; + this.metricData = metricData; + this.dirtySinkHelper = dirtySinkHelper; + } + + public void process(byte[] originData, JsonNode data) { + // 1. Extract the schema change type from the data; + if (!schemaChange) { + return; + } + String database; + String table; + try { + database = dynamicSchemaFormat.parse(data, databasePattern); + table = dynamicSchemaFormat.parse(data, tablePattern); + } catch (Exception e) { + if (exceptionPolicy == SchemaUpdateExceptionPolicy.THROW_WITH_STOP) { + throw new SchemaChangeHandleException( + String.format("Parse database, table from origin data failed, origin data: %s", + new String(originData)), + e); + } + LOGGER.warn("Parse database, table from origin data failed, origin data: {}", new String(originData), e); + if (exceptionPolicy == SchemaUpdateExceptionPolicy.LOG_WITH_IGNORE) { + dirtySinkHelper.invoke(new String(originData), DirtyType.JSON_PROCESS_ERROR, e); + } + if (metricData != null) { + metricData.invokeDirty(1, originData.length); + } + return; + } + Operation operation; + try { + JsonNode operationNode = Preconditions.checkNotNull(data.get("operation"), + "Operation node is null"); + operation = Preconditions.checkNotNull( + dynamicSchemaFormat.objectMapper.convertValue(operationNode, new TypeReference<Operation>() { + }), "Operation is null"); + } catch (Exception e) { + if (exceptionPolicy == SchemaUpdateExceptionPolicy.THROW_WITH_STOP) { + throw new SchemaChangeHandleException( + String.format("Extract Operation from origin data failed,origin data: %s", data), e); + } + LOGGER.warn("Extract Operation from origin data failed,origin data: {}", data, e); + handleDirtyData(data, originData, database, table, DirtyType.JSON_PROCESS_ERROR, e); + return; + } + String originSchema = dynamicSchemaFormat.extractDDL(data); + SchemaChangeType type = SchemaChangeUtils.extractSchemaChangeType(operation); + if (type == null) { + LOGGER.warn("Unsupported for schema-change: {}", originSchema); + return; + } + + // 2. Apply schema change; + switch (type) { + case ALTER: + handleAlterOperation(database, table, originData, originSchema, data, (AlterOperation) operation); + break; + case CREATE_TABLE: + doCreateTable(originData, database, table, type, originSchema, data, (CreateTableOperation) operation); + break; + case DROP_TABLE: + doDropTable(type, originSchema); + break; + case RENAME_TABLE: + doRenameTable(type, originSchema); + break; + case TRUNCATE_TABLE: + doTruncateTable(type, originSchema); + break; + default: + LOGGER.warn("Unsupported for {}: {}", type, originSchema); + } + } + + @Override + public void handleAlterOperation(String database, String table, byte[] originData, + String originSchema, JsonNode data, AlterOperation operation) { + if (operation.getAlterColumns() == null || operation.getAlterColumns().isEmpty()) { + if (exceptionPolicy == SchemaUpdateExceptionPolicy.THROW_WITH_STOP) { + throw new SchemaChangeHandleException( + String.format("Alter columns is empty, origin schema: %s", originSchema)); + } + LOGGER.warn("Alter columns is empty, origin schema: {}", originSchema); + return; + } + + Map<SchemaChangeType, List<AlterColumn>> typeMap = new LinkedHashMap<>(); + for (AlterColumn alterColumn : operation.getAlterColumns()) { + Set<SchemaChangeType> types = null; + try { + types = SchemaChangeUtils.extractSchemaChangeType(alterColumn); + Preconditions.checkState(!types.isEmpty(), "Schema change types is empty"); + } catch (Exception e) { + if (exceptionPolicy == SchemaUpdateExceptionPolicy.THROW_WITH_STOP) { + throw new SchemaChangeHandleException( + String.format("Extract schema change type failed, origin schema: %s", originSchema), e); + } + LOGGER.warn("Extract schema change type failed, origin schema: {}", originSchema, e); + } + if (types == null) { + continue; + } + if (types.size() == 1) { + SchemaChangeType type = types.stream().findFirst().get(); + typeMap.computeIfAbsent(type, k -> new ArrayList<>()).add(alterColumn); + } else { + // Handle change column, it only exists change column type and rename column in this scenario for now. + for (SchemaChangeType type : types) { + SchemaChangePolicy policy = policyMap.get(type); + if (policy == SchemaChangePolicy.ENABLE) { + LOGGER.warn("Unsupported for {}: {}", type, originSchema); + } else { + doSchemaChangeBase(type, policy, originSchema); + } + } + } + } + + if (!typeMap.isEmpty()) { + doAlterOperation(database, table, originData, originSchema, data, typeMap); + } + } + + @Override + public String doAddColumn(SchemaChangeType type, String originSchema) { + SchemaChangePolicy policy = policyMap.get(SchemaChangeType.DROP_TABLE); + if (policy == SchemaChangePolicy.ENABLE) { + throw new SchemaChangeHandleException(String.format("Unsupported for %s: %s", type, originSchema)); + } + doSchemaChangeBase(type, policy, originSchema); + return null; + } + + @Override + public String doChangeColumnType(SchemaChangeType type, String originSchema) { + SchemaChangePolicy policy = policyMap.get(SchemaChangeType.DROP_TABLE); + if (policy == SchemaChangePolicy.ENABLE) { + throw new SchemaChangeHandleException(String.format("Unsupported for %s: %s", type, originSchema)); + } + doSchemaChangeBase(type, policy, originSchema); + return null; + } + + @Override + public String doRenameColumn(SchemaChangeType type, String originSchema) { + SchemaChangePolicy policy = policyMap.get(SchemaChangeType.DROP_TABLE); + if (policy == SchemaChangePolicy.ENABLE) { + throw new SchemaChangeHandleException(String.format("Unsupported for %s: %s", type, originSchema)); + } + doSchemaChangeBase(type, policy, originSchema); + return null; + } + + @Override + public String doDropColumn(SchemaChangeType type, String originSchema) { + SchemaChangePolicy policy = policyMap.get(SchemaChangeType.DROP_TABLE); + if (policy == SchemaChangePolicy.ENABLE) { + throw new SchemaChangeHandleException(String.format("Unsupported for %s: %s", type, originSchema)); + } + doSchemaChangeBase(type, policy, originSchema); + return null; + } Review Comment: return null？ Why not to set method return type to void. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
