aloyszhang commented on code in PR #9792:
URL: https://github.com/apache/inlong/pull/9792#discussion_r1517221979
##########
inlong-sort/sort-formats/format-rowdata/format-rowdata-csv/src/main/java/org/apache/inlong/sort/formats/csv/CsvRowDataDeserializationSchema.java:
##########
@@ -241,12 +241,12 @@ public RowData deserializeInternal(@Nullable byte[]
message) {
rowData.setField(i, converters[i].convert(field));
}
}
-
return rowData;
} catch (Throwable t) {
- throw new RuntimeException(
- String.format("Could not properly deserialize csv.
Text=[%s].", text), t);
+ failureHandler.onParsingMsgFailure(message, new RuntimeException(
Review Comment:
`text` is more readable than `message`
##########
inlong-sort/sort-formats/format-rowdata/format-rowdata-kv/src/main/java/org/apache/inlong/sort/formats/kv/KvRowDataDeserializationSchema.java:
##########
@@ -170,9 +171,10 @@ public RowData deserializeInternal(byte[] bytes) throws
IOException {
}
return rowData;
} catch (Throwable t) {
- throw new IOException(
- String.format("Could not properly deserialize kv.
Text=[%s].", text), t);
+ failureHandler.onParsingMsgFailure(bytes, new RuntimeException(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
