baomingyu commented on code in PR #9792:
URL: https://github.com/apache/inlong/pull/9792#discussion_r1517404359
##########
inlong-sort/sort-formats/format-common/src/main/java/org/apache/inlong/sort/formats/inlongmsg/IgnoreFailureHandler.java:
##########
@@ -27,6 +27,11 @@ public class IgnoreFailureHandler implements FailureHandler {
private static final Logger LOG =
LoggerFactory.getLogger(IgnoreFailureHandler.class);
+ @Override
+ public void onParsingMsgFailure(Object msg, Exception exception) {
+ LOG.error("Could not properly serialize msg=[%s].", msg, exception);
Review Comment:
done
##########
inlong-sort/sort-formats/format-rowdata/format-rowdata-csv/src/main/java/org/apache/inlong/sort/formats/csv/CsvRowDataDeserializationSchema.java:
##########
@@ -241,12 +241,12 @@ public RowData deserializeInternal(@Nullable byte[]
message) {
rowData.setField(i, converters[i].convert(field));
}
}
-
return rowData;
} catch (Throwable t) {
- throw new RuntimeException(
- String.format("Could not properly deserialize csv.
Text=[%s].", text), t);
+ failureHandler.onParsingMsgFailure(message, new RuntimeException(
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
