fuweng11 commented on code in PR #12107:
URL: https://github.com/apache/inlong/pull/12107#discussion_r3246297392
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -215,7 +215,27 @@ public String save(InlongGroupRequest request, String
operator) {
if (request.getEnableZookeeper() == null) {
request.setEnableZookeeper(enableZookeeper ?
InlongConstants.ENABLE_ZK : InlongConstants.DISABLE_ZK);
}
- InlongGroupOperator instance =
groupOperatorFactory.getInstance(request.getMqType());
+
+ if (request.getEnableCreateResource() == null) {
+
request.setEnableCreateResource(InlongConstants.ENABLE_CREATE_RESOURCE);
+ }
+
+ if (request.getInlongGroupMode() == null) {
+ request.setInlongGroupMode(InlongConstants.STANDARD_MODE);
Review Comment:
When saving the group, no clustertag is assigned, so this verification is
unnecessary. Additionally, since the inlong_group table has default values set,
there is no need to explicitly set them in the code during saving.
<img width="1317" height="836"
alt="企业微信截图_ab049c8e-93eb-4d43-bcea-80d464e84832"
src="https://github.com/user-attachments/assets/3a1a9e3f-02cc-4d14-8b83-fabfbdde23f0";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
