vernedeng commented on code in PR #12107:
URL: https://github.com/apache/inlong/pull/12107#discussion_r3214995688
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -215,7 +215,27 @@ public String save(InlongGroupRequest request, String
operator) {
if (request.getEnableZookeeper() == null) {
request.setEnableZookeeper(enableZookeeper ?
InlongConstants.ENABLE_ZK : InlongConstants.DISABLE_ZK);
}
- InlongGroupOperator instance =
groupOperatorFactory.getInstance(request.getMqType());
+
+ if (request.getEnableCreateResource() == null) {
+
request.setEnableCreateResource(InlongConstants.ENABLE_CREATE_RESOURCE);
+ }
+
+ if (request.getInlongGroupMode() == null) {
+ request.setInlongGroupMode(InlongConstants.STANDARD_MODE);
Review Comment:
It is best to standardize the handling of all fields: either rely entirely
on database default values, or configure the default values within the
application logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
