This is an automated email from the ASF dual-hosted git repository.
justinchen pushed a commit to branch dev/1.3
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/dev/1.3 by this push:
new 33344e5dd93 [To dev/1.3] Pipe: Added log control for pipe receiver
auth exception (#16659) (#16660)
33344e5dd93 is described below
commit 33344e5dd9367f875e3728149d539faa2fa993ef
Author: Caideyipi <[email protected]>
AuthorDate: Tue Oct 28 11:39:53 2025 +0800
[To dev/1.3] Pipe: Added log control for pipe receiver auth exception
(#16659) (#16660)
---
.../protocol/thrift/IoTDBDataNodeReceiver.java | 4 ++--
.../db/queryengine/plan/statement/Statement.java | 4 ++++
.../crud/InsertMultiTabletsStatement.java | 8 +++++++
.../plan/statement/crud/InsertRowStatement.java | 25 ++++++++++++++++++++++
.../plan/statement/crud/InsertRowsStatement.java | 5 +++++
.../plan/statement/crud/InsertTabletStatement.java | 17 +++++++++++++++
.../pipe/PipeRuntimeSinkCriticalException.java | 2 +-
...RuntimeSinkRetryTimesConfigurableException.java | 6 ++++++
8 files changed, 68 insertions(+), 3 deletions(-)
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java
index de3ae290e89..9c04baba6d4 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java
@@ -693,7 +693,7 @@ public class IoTDBDataNodeReceiver extends
IoTDBFileReceiver {
LOGGER::warn,
"Receiver id = %s: Failure status encountered while executing
statement %s: %s",
receiverId.get(),
- statement,
+ statement.getPipeLoggingString(),
result);
return statement.accept(STATEMENT_STATUS_VISITOR, result);
}
@@ -702,7 +702,7 @@ public class IoTDBDataNodeReceiver extends
IoTDBFileReceiver {
LOGGER::warn,
"Receiver id = %s: Exception encountered while executing statement
%s: ",
receiverId.get(),
- statement,
+ statement.getPipeLoggingString(),
e);
return statement.accept(STATEMENT_EXCEPTION_VISITOR, e);
} finally {
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/Statement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/Statement.java
index 822c3eacef0..57cd67229fa 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/Statement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/Statement.java
@@ -66,4 +66,8 @@ public abstract class Statement extends StatementNode {
AuthorityChecker.SUPER_USER.equals(userName),
"Only the admin user can perform this operation");
}
+
+ public String getPipeLoggingString() {
+ return toString();
+ }
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertMultiTabletsStatement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertMultiTabletsStatement.java
index a2b9c63e1e7..8225d2f6020 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertMultiTabletsStatement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertMultiTabletsStatement.java
@@ -160,4 +160,12 @@ public class InsertMultiTabletsStatement extends
InsertBaseStatement {
.reduce(0L, Long::sum)
: 0);
}
+
+ @Override
+ public String toString() {
+ return "InsertMultiTabletsStatement{"
+ + "insertTabletStatementList="
+ + insertTabletStatementList
+ + '}';
+ }
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowStatement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowStatement.java
index 3422fd7311f..faa46cadd9d 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowStatement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowStatement.java
@@ -56,6 +56,7 @@ import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.Objects;
public class InsertRowStatement extends InsertBaseStatement implements
ISchemaValidation {
@@ -476,4 +477,28 @@ public class InsertRowStatement extends
InsertBaseStatement implements ISchemaVa
+ InsertNodeMemoryEstimator.sizeOfValues(values, measurementSchemas)
+ RamUsageEstimator.sizeOf(measurementIsAligned);
}
+
+ @Override
+ public String getPipeLoggingString() {
+ return "InsertRowNode{"
+ + "devicePath="
+ + devicePath
+ + ", time="
+ + time
+ + ", valueLength="
+ + (Objects.nonNull(values) ? values.length : 0)
+ + '}';
+ }
+
+ @Override
+ public String toString() {
+ return "InsertRowNode{"
+ + "devicePath="
+ + devicePath
+ + ", time="
+ + time
+ + ", values="
+ + Arrays.toString(values)
+ + '}';
+ }
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java
index 41ad8516db7..0e7b65371b5 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java
@@ -179,4 +179,9 @@ public class InsertRowsStatement extends
InsertBaseStatement {
.reduce(0L, Long::sum)
: 0);
}
+
+ @Override
+ public String toString() {
+ return "InsertRowsStatement{" + "insertRowStatementList=" +
insertRowStatementList + '}';
+ }
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java
index 84250173ed8..f73443fd17b 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java
@@ -489,4 +489,21 @@ public class InsertTabletStatement extends
InsertBaseStatement implements ISchem
+ InsertNodeMemoryEstimator.sizeOfBitMapArray(bitMaps)
+ InsertNodeMemoryEstimator.sizeOfColumns(columns, measurementSchemas);
}
+
+ @Override
+ public String toString() {
+ return "InsertTabletStatement{"
+ + "devicePath="
+ + devicePath
+ + ", measurements="
+ + Arrays.toString(measurements)
+ + ", rowCount="
+ + rowCount
+ + ", timeRange=["
+ + (Objects.nonNull(times) && times.length > 0
+ ? times[0] + ", " + times[times.length - 1]
+ : "")
+ + "]"
+ + '}';
+ }
}
diff --git
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkCriticalException.java
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkCriticalException.java
index e44ed51f489..ccc91f7fef1 100644
---
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkCriticalException.java
+++
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkCriticalException.java
@@ -93,7 +93,7 @@ public class PipeRuntimeSinkCriticalException extends
PipeRuntimeCriticalExcepti
@Override
public String toString() {
- return "PipeRuntimeConnectorCriticalException{"
+ return "PipeRuntimeSinkCriticalException{"
+ "message='"
+ getMessage()
+ "', timeStamp="
diff --git
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkRetryTimesConfigurableException.java
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkRetryTimesConfigurableException.java
index 4143d2131e7..62b54334a93 100644
---
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkRetryTimesConfigurableException.java
+++
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkRetryTimesConfigurableException.java
@@ -33,4 +33,10 @@ public class PipeRuntimeSinkRetryTimesConfigurableException
public int getRetryTimes() {
return retryTimes;
}
+
+ // We do not record the timestamp here for logger reduction detection
+ @Override
+ public String toString() {
+ return "PipeRuntimeSinkRetryTimesConfigurableException{" + "message='" +
getMessage() + "}";
+ }
}