This is an automated email from the ASF dual-hosted git repository.
justinchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/master by this push:
new aa899ccf8f5 Pipe: Added log control for pipe receiver auth exception
(#16659)
aa899ccf8f5 is described below
commit aa899ccf8f50584100cd169d17c81b6679d06db2
Author: Caideyipi <[email protected]>
AuthorDate: Tue Oct 28 11:47:27 2025 +0800
Pipe: Added log control for pipe receiver auth exception (#16659)
---
.../protocol/thrift/IoTDBDataNodeReceiver.java | 4 ++--
.../db/queryengine/plan/statement/Statement.java | 4 ++++
.../crud/InsertMultiTabletsStatement.java | 8 ++++++++
.../plan/statement/crud/InsertRowStatement.java | 24 ++++++++++++++++++++++
.../plan/statement/crud/InsertRowsStatement.java | 5 +++++
.../plan/statement/crud/InsertTabletStatement.java | 17 +++++++++++++++
.../pipe/PipeRuntimeSinkCriticalException.java | 2 +-
...RuntimeSinkRetryTimesConfigurableException.java | 6 ++++++
8 files changed, 67 insertions(+), 3 deletions(-)
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java
index 8e14571074b..4096f5f931b 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java
@@ -831,7 +831,7 @@ public class IoTDBDataNodeReceiver extends
IoTDBFileReceiver {
LOGGER::warn,
"Receiver id = %s: Failure status encountered while executing
statement %s: %s",
receiverId.get(),
- statement,
+ statement.getPipeLoggingString(),
result);
return statement.accept(STATEMENT_STATUS_VISITOR, result);
}
@@ -840,7 +840,7 @@ public class IoTDBDataNodeReceiver extends
IoTDBFileReceiver {
LOGGER::warn,
"Receiver id = %s: Exception encountered while executing statement
%s: ",
receiverId.get(),
- statement,
+ statement.getPipeLoggingString(),
e);
return statement.accept(STATEMENT_EXCEPTION_VISITOR, e);
} finally {
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/Statement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/Statement.java
index 62d73c56c4c..5b31f08ca67 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/Statement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/Statement.java
@@ -64,4 +64,8 @@ public abstract class Statement extends StatementNode {
final MPPQueryContext context) {
throw new UnsupportedOperationException("Method not implemented yet");
}
+
+ public String getPipeLoggingString() {
+ return toString();
+ }
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertMultiTabletsStatement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertMultiTabletsStatement.java
index f1816347c21..cc3c644d140 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertMultiTabletsStatement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertMultiTabletsStatement.java
@@ -200,4 +200,12 @@ public class InsertMultiTabletsStatement extends
InsertBaseStatement {
protected void subRemoveAttributeColumns(List<Integer> columnsToKeep) {
insertTabletStatementList.forEach(InsertBaseStatement::removeAttributeColumns);
}
+
+ @Override
+ public String toString() {
+ return "InsertMultiTabletsStatement{"
+ + "insertTabletStatementList="
+ + insertTabletStatementList
+ + '}';
+ }
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowStatement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowStatement.java
index 52901f6f7fe..235cd63c24c 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowStatement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowStatement.java
@@ -548,4 +548,28 @@ public class InsertRowStatement extends
InsertBaseStatement implements ISchemaVa
values = columnsToKeep.stream().map(i -> values[i]).toArray();
}
}
+
+ @Override
+ public String getPipeLoggingString() {
+ return "InsertRowNode{"
+ + "deviceID="
+ + deviceID
+ + ", time="
+ + time
+ + ", valueLength="
+ + (Objects.nonNull(values) ? values.length : 0)
+ + '}';
+ }
+
+ @Override
+ public String toString() {
+ return "InsertRowNode{"
+ + "deviceID="
+ + deviceID
+ + ", time="
+ + time
+ + ", values="
+ + Arrays.toString(values)
+ + '}';
+ }
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java
index ad9e9ff4546..3e2c1088cf9 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertRowsStatement.java
@@ -237,4 +237,9 @@ public class InsertRowsStatement extends
InsertBaseStatement {
protected void subRemoveAttributeColumns(List<Integer> columnsToKeep) {
insertRowStatementList.forEach(InsertBaseStatement::removeAttributeColumns);
}
+
+ @Override
+ public String toString() {
+ return "InsertRowsStatement{" + "insertRowStatementList=" +
insertRowStatementList + '}';
+ }
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java
index 749a2422b01..efb4746b9b3 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertTabletStatement.java
@@ -640,4 +640,21 @@ public class InsertTabletStatement extends
InsertBaseStatement implements ISchem
nullBitMaps = columnsToKeep.stream().map(i ->
nullBitMaps[i]).toArray(BitMap[]::new);
}
}
+
+ @Override
+ public String toString() {
+ return "InsertTabletStatement{"
+ + "deviceIDs="
+ + Arrays.toString(deviceIDs)
+ + ", measurements="
+ + Arrays.toString(measurements)
+ + ", rowCount="
+ + rowCount
+ + ", timeRange=["
+ + (Objects.nonNull(times) && times.length > 0
+ ? times[0] + ", " + times[times.length - 1]
+ : "")
+ + "]"
+ + '}';
+ }
}
diff --git
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkCriticalException.java
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkCriticalException.java
index e44ed51f489..ccc91f7fef1 100644
---
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkCriticalException.java
+++
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkCriticalException.java
@@ -93,7 +93,7 @@ public class PipeRuntimeSinkCriticalException extends
PipeRuntimeCriticalExcepti
@Override
public String toString() {
- return "PipeRuntimeConnectorCriticalException{"
+ return "PipeRuntimeSinkCriticalException{"
+ "message='"
+ getMessage()
+ "', timeStamp="
diff --git
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkRetryTimesConfigurableException.java
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkRetryTimesConfigurableException.java
index 4143d2131e7..62b54334a93 100644
---
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkRetryTimesConfigurableException.java
+++
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/pipe/PipeRuntimeSinkRetryTimesConfigurableException.java
@@ -33,4 +33,10 @@ public class PipeRuntimeSinkRetryTimesConfigurableException
public int getRetryTimes() {
return retryTimes;
}
+
+ // We do not record the timestamp here for logger reduction detection
+ @Override
+ public String toString() {
+ return "PipeRuntimeSinkRetryTimesConfigurableException{" + "message='" +
getMessage() + "}";
+ }
}
