Don't hardcode specific networks to skip Don't skip the NAT'ed virtualbox network. Let users deal with it.
Project: http://git-wip-us.apache.org/repos/asf/jclouds-labs/repo Commit: http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/5de4c0aa Tree: http://git-wip-us.apache.org/repos/asf/jclouds-labs/tree/5de4c0aa Diff: http://git-wip-us.apache.org/repos/asf/jclouds-labs/diff/5de4c0aa Branch: refs/heads/master Commit: 5de4c0aa557cfd2245645e108c9c02f790839404 Parents: 234f67e Author: Svetoslav Neykov <[email protected]> Authored: Wed Jul 19 20:52:47 2017 +0300 Committer: Svetoslav Neykov <[email protected]> Committed: Tue Aug 1 14:48:26 2017 +0300 ---------------------------------------------------------------------- .../org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java | 2 -- 1 file changed, 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/5de4c0aa/vagrant/src/main/java/org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java ---------------------------------------------------------------------- diff --git a/vagrant/src/main/java/org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java b/vagrant/src/main/java/org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java index 838338d..926686b 100644 --- a/vagrant/src/main/java/org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java +++ b/vagrant/src/main/java/org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java @@ -165,8 +165,6 @@ public class VagrantComputeServiceAdapter implements ComputeServiceAdapter<Vagra Collection<String> ips = new ArrayList<String>(); while (m.find()) { String network = m.group(1); - // TODO figure out a more generic approach to ignore unreachable networkds (this one is the NAT'd address). - if (network.startsWith("10.")) continue; ips.add(network); } return ips;
