Don't hardcode specific networks to skip Don't skip the NAT'ed virtualbox network. Let users deal with it.
Project: http://git-wip-us.apache.org/repos/asf/jclouds-labs/repo Commit: http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/b2f34c33 Tree: http://git-wip-us.apache.org/repos/asf/jclouds-labs/tree/b2f34c33 Diff: http://git-wip-us.apache.org/repos/asf/jclouds-labs/diff/b2f34c33 Branch: refs/heads/2.0.x Commit: b2f34c331cbf6fa6d956c3a404333fd3f6503b20 Parents: 82d77ec Author: Svetoslav Neykov <[email protected]> Authored: Wed Jul 19 20:52:47 2017 +0300 Committer: Svetoslav Neykov <[email protected]> Committed: Tue Aug 1 14:55:42 2017 +0300 ---------------------------------------------------------------------- .../org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java | 2 -- 1 file changed, 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jclouds-labs/blob/b2f34c33/vagrant/src/main/java/org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java ---------------------------------------------------------------------- diff --git a/vagrant/src/main/java/org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java b/vagrant/src/main/java/org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java index 838338d..926686b 100644 --- a/vagrant/src/main/java/org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java +++ b/vagrant/src/main/java/org/jclouds/vagrant/compute/VagrantComputeServiceAdapter.java @@ -165,8 +165,6 @@ public class VagrantComputeServiceAdapter implements ComputeServiceAdapter<Vagra Collection<String> ips = new ArrayList<String>(); while (m.find()) { String network = m.group(1); - // TODO figure out a more generic approach to ignore unreachable networkds (this one is the NAT'd address). - if (network.startsWith("10.")) continue; ips.add(network); } return ips;
