jbonofre commented on code in PR #2839:
URL: https://github.com/apache/karaf/pull/2839#discussion_r3995346451
##########
tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/DockerfileMojo.java:
##########
@@ -31,29 +31,46 @@
@Mojo(name = "dockerfile", defaultPhase = LifecyclePhase.PACKAGE)
public class DockerfileMojo extends MojoSupport {
+ private static final String DEFAULT_IMAGE = "eclipse-temurin:11-jre";
+ private static final String DEFAULT_COMMAND = "[\"karaf\", \"run\"]";
+
@Parameter(defaultValue = "${project.build.directory}")
private File destDir;
@Parameter(defaultValue = "${project.build.directory}/assembly")
private File assembly;
- @Parameter(defaultValue = "[\"karaf\", \"run\"]")
+ @Parameter(defaultValue = DEFAULT_COMMAND)
Review Comment:
`command` has no `property` binding, unlike `image` below. The new docs list
both parameters as equivalently configurable, but `-Dcommand=...` will silently
be ignored (only setting via `<configuration>` in the POM works).
```suggestion
@Parameter(defaultValue = DEFAULT_COMMAND, property = "command")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
