Alwaysgaurav1 commented on PR #2839: URL: https://github.com/apache/karaf/pull/2839#issuecomment-5644755191
Thanks for the review, @jbonofre! Good catch on both points. I've pushed an update addressing this feedback: 1. **CLI property binding for `command`**: Added `property = "command"` to the `@Parameter` annotation in `DockerfileMojo.java` so that `-Dcommand=...` works as expected. 2. **Updated `examples/karaf-docker-example`**: Both `static-dist` and `dynamic-dist` specify `<javase>17</javase>`, so I configured `<image>eclipse-temurin:17-jre</image>` in their `dockerfile` executions to align with Java 17 (preventing the default Java 11 JRE from being used). I also updated the legacy `FROM openjdk:8-jre` sample traces in the example's `README.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
