MarianMacik commented on PR #239:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/239#issuecomment-1746940961

   > 
   > 
   > The way it was before was causing some sort of race condition between the 
main test and the no-webhooks test, if A started before, then when it finished 
the B would fail and vice-verse, it because the namespace was not getting 
cleaned after the first test was finished, the beforeAll in this case, would 
only clean the env after everything was finished, and it was not what was 
needed in this case.
   
   @spolti 
   Yes, before everything was in one ordered section, now each of those is in 
one serial section, so they are mutually exclusive. I was thinking about 
putting the setup inside the ordered section now, so basically `It("Prepare the 
environment", func() {` would be changed to `BeforeAll(func() {`, nothing else. 
The serial part now guarantees that the tests will not run concurrently and 
`BeforeAll` would be run just inside the context of the ordered section, same 
as `AfterAll` is now being executed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to