spolti commented on PR #239: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/239#issuecomment-1747056477
> > @spolti Looks good now. About the e2e tests, we could have the tests setup in the `BeforeAll` function unless your intention was to have the applying of the CRDs as a dedicated test. > > The way it was before was causing some sort of race condition between the main test and the no-webhooks test, if A started before, then when it finished the B would fail and vice-verse, it because the namespace was not getting cleaned after the first test was finished, the beforeAll in this case, would only clean the env after everything was finished, and it was not what was needed in this case. I meant, the `AfterAll`, not the BeforeAll :) sry for the typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
