wmedvede commented on PR #283: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/283#issuecomment-1770233281
> I like this initial (big) step. Therefore, can we please have one package? It's uncommon in golang to have that many packages for this implementation. Especially in the scope of `api` package. This is a convention for the CRD types, might be confusing to introduce this here. > > What I recommend is to create one single `controllers/discovery` package and in there, we create our files with meaningful prefixes such as `parser_types.go`. Also, we can implement it by adopting lowercase letters in the func/types and exposing just the discovery engine like: `discovery.NewHandler(workflow).Do()`. Just an example. > > The other modules/packages don't care about unexposed data structures that we need to do the discovery. Good suggestions, I'll apply all. Many thanks Ricardo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
