wmedvede commented on code in PR #283: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/283#discussion_r1378652213
########## controllers/discovery/uri_parser.go: ########## @@ -0,0 +1,134 @@ +package discovery + +import ( + "fmt" + v1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "regexp" + "strings" +) + +const ( + // valid namespace, name, or label name. + dns1123LabelFmt string = "[a-z0-9]([-a-z0-9]*[a-z0-9])?" Review Comment: I couldn't find this const public there, nor in the "validation" package, we have methods to validate, but not te expression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
