fjtirado commented on code in PR #3278:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3278#discussion_r1384736973
##########
jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/canonical/descriptors/ExpressionUtils.java:
##########
@@ -108,7 +108,7 @@ public static Expression getLiteralExpr(Object object) {
} else if (object instanceof Character) {
return new CharLiteralExpr(((Character) object));
} else if (object instanceof Long) {
- return new LongLiteralExpr(object.toString());
+ return new LongLiteralExpr(object + "L");
Review Comment:
I guess you verify the "L" is not added automatically (which the library
should do, in my opinion). In such case, good catch ;). The only concern is
that, if in future, we update the version of the library, they might add it in
a future implementation and if they do not check if already there, this will
fail, but there is nothing we can do to prevent that, so lets keep it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
