wmedvede commented on code in PR #3278:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3278#discussion_r1384796468
##########
api/kogito-api/src/main/java/org/kie/kogito/internal/utils/ConversionUtils.java:
##########
@@ -81,6 +81,8 @@ public static <T> Collection<T> convertToCollection(Object
value, Class<T> clazz
public static <T> T convert(Object value, Class<T> clazz, Function<Object,
String> stringConverter) {
if (value == null || clazz.isAssignableFrom(value.getClass())) {
return clazz.cast(value);
+ } else if (isConvertibleFromStringJavaBaseType(clazz)) {
Review Comment:
I see what you mean, but I think a separate method helps to not keep this
stuff so long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
