mareknovotny commented on code in PR #5583:
URL:
https://github.com/apache/incubator-kie-drools/pull/5583#discussion_r1404260154
##########
.github/workflows/pr-drools.yml:
##########
@@ -43,6 +43,7 @@ jobs:
uses:
apache/incubator-kie-kogito-pipelines/.ci/actions/build-chain@main
env:
BUILD_MVN_OPTS_CURRENT: -Dfull
+ MAVEN_OPTS: "-Dfile.encoding=UTF-8"
Review Comment:
maybe the thing is about test and build of related maven plugin, as pointed
somethere on SO, the compiler plugin is not the only place to specify the
encoding. While `-Dfile.encoding` is the config for environment property it is
better to add that to that plugin for tests? is it Surefire or other one? like
https://stackoverflow.com/questions/17656475/maven-source-encoding-in-utf-8-not-working
or something similar in case of other maven plugin used in this case?
```
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>-Dfile.encoding=UTF-8</argLine>
</configuration>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
