tkobayas commented on code in PR #5583:
URL:
https://github.com/apache/incubator-kie-drools/pull/5583#discussion_r1405887815
##########
.github/workflows/pr-drools.yml:
##########
@@ -43,6 +43,7 @@ jobs:
uses:
apache/incubator-kie-kogito-pipelines/.ci/actions/build-chain@main
env:
BUILD_MVN_OPTS_CURRENT: -Dfull
+ MAVEN_OPTS: "-Dfile.encoding=UTF-8"
Review Comment:
@mareknovotny Thanks for the suggestion. Actually, the issue raised in
maven-compiler-plugin.
```
2023-11-27T03:01:52.3028049Z [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile
(default-testCompile) on project drools-decisiontables: Error while storing the
mojo status: Input length = 1 -> [Help 1]
2023-11-27T03:01:52.3030138Z
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile
(default-testCompile) on project drools-decisiontables: Error while storing the
mojo status
```
But your suggestion inspires me to re-check maven-compiler-plugin
configuration and I found that it wasn't configured in `<pluginManagement>`. So
I added `<encoding>UTF-8</encoding>` and confirmed that the issue is resolved
even without the `MAVEN_OPTS` fix.
https://github.com/apache/incubator-kie-drools/pull/5590/files#diff-150bdf617c2dc80dc5a9d5f1313f44a73950a96ca7b166b79a35b15f4c84f193R1327-R1333
I think both are good to have, so proceeding the PR.
https://github.com/apache/incubator-kie-drools/pull/5590
Thanks!
(Btw, maven-surefire-plugin is already configured with UTF-8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
