tchughesiv commented on code in PR #311:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#discussion_r1408670546
##########
controllers/profiles/common/app_properties_test.go:
##########
@@ -128,7 +128,7 @@ func
Test_appPropertyHandler_WithServicesWithUserOverrides(t *testing.T) {
generatedProps, propsErr = properties.LoadString(props)
assert.NoError(t, propsErr)
assert.Equal(t, 9, len(generatedProps.Keys()))
- assert.Equal(t,
"http://"+platform.Name+"-"+DataIndexName+"."+platform.Namespace+"/processes";,
generatedProps.GetString(dataIndexServiceUrlProperty, ""))
+ assert.Equal(t,
"http://"+platform.Name+"-"+DataIndexServiceName+"."+platform.Namespace+"/processes";,
generatedProps.GetString(dataIndexServiceUrlProperty, ""))
Review Comment:
missed this earlier... please add a similar unit test that ensures job
service is getting added as an app property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
