tchughesiv commented on code in PR #311:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#discussion_r1408672193
##########
controllers/profiles/common/app_properties.go:
##########
@@ -156,7 +194,7 @@ func (a *appPropertyHandler) withDataIndexServiceUrl()
AppPropertyHandler {
if profiles.IsProdProfile(a.workflow) && dataIndexEnabled(a.platform) {
a.addDefaultMutableProperty(
dataIndexServiceUrlProperty,
- fmt.Sprintf("%s://%s.%s/processes",
dataIndexServiceUrlProtocol, GetDataIndexName(a.platform),
a.platform.Namespace),
+ fmt.Sprintf("%s://%s.%s/processes",
dataIndexServiceUrlProtocol, GetServiceName(a.platform.Name, DataIndexService),
a.platform.Namespace),
Review Comment:
does a job service app property also need to be added here so that workflows
know how to communicate to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
