tarilabs commented on PR #5621:
URL: 
https://github.com/apache/incubator-kie-drools/pull/5621#issuecomment-1859782681

   > I'll look to improve that, and it would be extemely helpful if you could 
share some suggestion on what to benchmark exactly, namely:
   > 
   > 1. I picked some infix expression from the code base, but I'm not sure if 
those are actually representative of the business domain
   > 2. between the three different codepath executions I see in the benchmark, 
I'm not sure which is the most important, i.e. which one should I focus on the 
mostly
   
   CompiledButInterpreted is usually your "non-negotiable", because is the one 
where you have a DMN engine at runtime initialized with a DMN model, and you 
evaluate multiple times that DMN model with different set of inputs. So it's 
the one you typically exercise the most on the field.
   
   The [fully] Interpreted have a play with the KIE Sandbox style of 
interacting with the engine, because every time with JIT DMN you compile the 
.dmn and evaluate with the inputs (on a tangent here we experimented with 
Caffeine to cache the result in JIT DMN so that if you are testing the same DMN 
model, you don't need to recompile it, but unf. it was still an experimental 
extension, not sure if this can be revisited now). However the performance of 
evaluation here are clearly negligible if compared to most time is typically 
compiling the model.
   
   The CompiledJava kicks in only if you are emitting the compilation and using 
that (not the default, see [comment 
here](https://kie.zulipchat.com/#narrow/stream/381961-drools-dev/topic/dmn.20development/near/407970874:~:text=still%20regret%20we%20were%20not%20allowed%20bandwith%20to%20complete%20for%20edge%20cases)).
   
   I would also suggest to take a look at algebric expression benchmarks (iirc 
we had a few) so to have a more "macro"-benchmark for reference in this scope?
   
   Hope this helps!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to