mariofusco commented on PR #5621: URL: https://github.com/apache/incubator-kie-drools/pull/5621#issuecomment-1859830030
@gitgabrio Personally I don't have a strong opinion on which of the 2 versions is more readable or maintainable, it is really a matter of tastes and I don't want to argue on them. Regarding the performances, if we're serious about them my suggestion is not only benchmarking more extensively the effects of this change, as also asked by @tarilabs, but also running some proper profiling sessions to better figure out where we are consuming time and how we can improve. For instance I have the _feeling_ that creating a new instance of that `ClassIdentifierTuple` at each and every evaluation of a numeric expression and use it as the key for the map containing the function to be executed on its operands is a non-negligible waste and could be easily avoided, but again this is just a wild guess and I'd prefer to make changes driven by the evidence of a profiling session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
