tchughesiv commented on code in PR #345:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/345#discussion_r1456008420
##########
controllers/platform/services/services.go:
##########
@@ -67,6 +67,22 @@ type Platform interface {
GenerateWorkflowProperties() (*properties.Properties, error)
// GenerateServiceProperties returns a property object that contains
the application properties required by the service deployment
GenerateServiceProperties() (*properties.Properties, error)
+
+ // ServiceSetInSpec returns true if the service is set in the spec.
+ ServiceSetInSpec() bool
+ // ServiceEnabledInSpec returns true if the service is enabled in the
spec.
+ ServiceEnabledInSpec() bool
+ // ServiceBaseUrl returns the base url of the service
+ ServiceBaseUrl() string
+ // GetServiceBaseUrl returns the base url of the service, based on
whether using local or cluster-scoped service.
+ GetServiceBaseUrl() string
+ // GetServiceUrl returns the service url, based on whether using local
or cluster-scoped service.
+ GetServiceUrl() string
+ // ServiceEnabled returns true if the service is enabled in either the
spec or the status.clusterPlatformRef.
+ ServiceEnabled() bool
Review Comment:
done
##########
controllers/profiles/common/app_properties_test.go.removed:
##########
@@ -127,7 +127,7 @@ func
Test_appPropertyHandler_WithServicesWithUserOverrides(t *testing.T) {
platform := test.GetBasePlatform()
platform.Namespace = ns
platform.Spec = v1alpha08.SonataFlowPlatformSpec{
- Services: v1alpha08.ServicesPlatformSpec{
+ Services: &v1alpha08.ServicesPlatformSpec{
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
