jordigilh commented on PR #345:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/345#issuecomment-1897502902

   Let me see if I understand this:
   * A platform CR applies to a namespace, whereas a cluster platform is seen 
by all platforms as a reference object where others can use to retrieve the 
services configuration to share. 
   * A cluster platform CR can be `active` or not active, or considered 
`secondary` and `duplicated`.
   * Multiple cluster platform CRs can be stored in the cluster, but only 1 is 
active and used as reference by other platforms.
   * Changes to a referenced platform (being the platform referenced in the 
active cluster platform CR) are propagated to the platform CRs using its 
services.
   * At the same time, changes to the active cluster platform CR will force a 
reconciliation to all platform CRs that reference it, although currently it 
won't force a reconciliation to the deployed services, rather create new ones 
(mentioned as a comment in the PR).
   * When the active cluster platform is deleted, the platforms that consumed 
the active cluster platform remove their references in the status spec, but 
they won't remove the services generated. On the other hand, if the service 
spec is changed, that just changes the serviceURL field in the status but not 
the configmap properties of the services or the deployments
   
   Questions:
   * What should happen when a referenced platform CR (referenced by an active 
cluster platform CR) is deleted from the cluster? should it trigger a 
reconciliation to all platforms that used its service spec via the cluster 
platform CR and delete their service specs? 
   
   I find strange that  the services spec in a platform CR can be either a 
reference to platforms that are configured to inherit from the cluster 
platform, or just consumers, depending on the information of a CR. 
   In my opinion, it would make more sense to have the cluster platform define 
the services and let the platforms inherit those. It's a one way relationship 
top to bottom and ensures that changes to the cluster platform CR alone trigger 
changes to the platforms, rather than both cluster platform CRs and platform 
CRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to