tchughesiv commented on code in PR #345:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/345#discussion_r1457754708
##########
controllers/platform/services/services.go:
##########
@@ -271,6 +337,56 @@ func (j JobService) GetServiceCmName() string {
return fmt.Sprintf("%s-props", j.GetServiceName())
}
+func (j JobService) SetServiceUrlInStatus(clusterRefPlatform
*operatorapi.SonataFlowPlatform) {
+ psJS := NewJobService(clusterRefPlatform)
+ if !isServicesSet(j.platform) && psJS.IsServiceEnabledInSpec() {
Review Comment:
no, we do not affect any changes to the services or their configurations
with this change. this change is all about workflow configurations... to give
the user the option of specifying something globally, and lower level users the
ability to override those cluster services by setting their own
`SonataFlowPlatform.spec.services` locally. They could actually set it to `nil`
if they didn't want to use any deployed services (cluster or local).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
