tchughesiv commented on code in PR #345:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/345#discussion_r1457756332
##########
controllers/platform/services/services.go:
##########
@@ -271,6 +337,56 @@ func (j JobService) GetServiceCmName() string {
return fmt.Sprintf("%s-props", j.GetServiceName())
}
+func (j JobService) SetServiceUrlInStatus(clusterRefPlatform
*operatorapi.SonataFlowPlatform) {
+ psJS := NewJobService(clusterRefPlatform)
+ if !isServicesSet(j.platform) && psJS.IsServiceEnabledInSpec() {
Review Comment:
> What about the configmap application.properties for the services?
shouldn't that be reconciled as well? Removing the data index service will
impact the job service application properties.
there will be no impact to a job service configuration as a user only has 2
choices -
1. leverage all cluster-level services
2. leverage none of the cluster-level services
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
