rodrigonull commented on PR #1165: URL: https://github.com/apache/incubator-kie-kogito-pipelines/pull/1165#issuecomment-1914526511
Thank you for the PR @cimbalek. The code LGTM, although I think it could be simplified using @jstastny-cz suggestion to use the env.AGENT_LABEL and set that env var in the KIE folder on Jenkins: https://ci-builds.apache.org/job/KIE/. In this case we wouldn't need to have a function to get the labels we would just need to set `label env.AGENT_LABEL` in all Jenkins / groovy files so then when we have a faulty node we could just go to the KIE folder configuration and update the AGENT_LABEL env var there to exclude the faulty nodes. Using that approach we remove the need of an extra env var for the faulty nodes. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
