jstastny-cz commented on code in PR #1165:
URL: 
https://github.com/apache/incubator-kie-kogito-pipelines/pull/1165#discussion_r1472653990


##########
README.md:
##########
@@ -132,9 +136,35 @@ NOTE: test coverage analysis is executed only by **Jenkins 
PR simple build&test*
 
 # Configuration of pipelines
 
+## Source Code
+*Note: Creating separate readme.md documenting how-tos and best practices for 
implementing pipelines might be useful*
+
+### Pipelines
+In this repository two types of pipelines can be found:
+- **Kogito pipelines** (obviously) - located in the 
[.ci/jenkins](./.ci/jenkins) folder
+- **Seed jobs library** - see [Jenkins documentation](../docs/jenkins.md)
+
+### Shared pipeline libraries
+Apart from these pipelines, the `jenkins-pipeline-shared-libraries` are also 
stored in this repository. Functions and classes contained in these libraries 
can be freely used in all pipelines located under [KIE Jenkins 
folder](https://ci-builds.apache.org/job/KIE). Just include correct import and 
annotation in your Jenkinsfile:
+```
+import org.jenkinsci.plugins.workflow.libs.Library
+
+@Library('jenkins-pipeline-shared-libraries')_
+```
+For more details please see our [Jenkins pipelines shared libraries 
documentation](./jenkins-pipeline-shared-libraries/README.md) and [Jenkins.io 
documentation](https://www.jenkins.io/doc/book/pipeline/shared-libraries/)
+
 ## Jenkins
 
-All pipelines can be found in [kogito Jenkins 
folder](https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito).
+### Jenkins KIE folder
+
+All KIE jobs (pipelines) can be found  in [KIE Jenkins 
folder](https://ci-builds.apache.org/job/KIE)<br />
+For this folder and all its descendants there is several useful things set at 
this folder level:<br />
+- **Pipeline library** - accessible in pipelines under name 
`jenkins-pipeline-shared-libraries` it gives access to some useful functions 
used throughout various KIE pipelines. More details can be found in our 
[Jenkins pipeline shared libraries 
documentation](./jenkins-pipeline-shared-libraries/README.md) and in the 
[previous chapter](#source-code)
+- **Environment Variables** - Environment variables set here are inherited by 
all the folders and jobs located in the [KIE 
folder](https://ci-builds.apache.org/job/KIE) tree in Jenkins. However, they 
can be overridden or extended. You can modify the variables by clicking 
`Configure` in the left menu (if you have necessary permissions). Currently 
present Environment Variables are:
+- - **FAULTY_NODES** - Comma separated list of Jenkins execution nodes that 
are faulty in some way and cause KIE jobs to fail. This variable is expected by 
the *pipeline-library* function `getLabel(String label)`, which extends desired 
`label` by expression that ensures avoiding these faulty nodes. This way we can 
increase durability of KIE automation by the time the Apache CI team fixes the 
issue with faulty node. 

Review Comment:
   ```suggestion
     - **FAULTY_NODES** - Comma separated list of Jenkins execution nodes that 
are faulty in some way and cause KIE jobs to fail. This variable is expected by 
the *pipeline-library* function `getLabel(String label)`, which extends desired 
`label` by expression that ensures avoiding these faulty nodes. This way we can 
increase durability of KIE automation by the time the Apache CI team fixes the 
issue with faulty node. 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to