dmartinol commented on code in PR #367:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/367#discussion_r1473003933
##########
controllers/profiles/common/properties/discovery.go:
##########
@@ -99,6 +99,7 @@ func generateDiscoveryProperties(ctx context.Context, catalog
discovery.ServiceC
mpProperty :=
generateMicroprofileServiceCatalogProperty(plainUri)
klog.V(log.I).Infof("Generating
microprofile service catalog property %s=%s.", mpProperty, address)
result.MustSet(mpProperty, address)
+ result.MustSet(k,
"http://localhost:8080";)
Review Comment:
this is a workaround to avoid the problem we saw yesterday.
if the `managed-props` does not override the value of the original property,
the platform would anyway parse it and may raise a startup error like:
```
2024-01-29 16:15:52,397 orderprocessing-5f658b4c9d-wtmnp ERROR
[io.quarkus.runtime.Application:-1] (Quarkus Main Thread) Failed to start
application (with profile [dev]): java.lang.RuntimeException: Failed to start
quarkus
...
Caused by: jakarta.enterprise.inject.spi.DeploymentException:
java.lang.IllegalArgumentException: Unsupported scheme for the http connector
in URL: services.v1/event-listener
...
```
(the property value being `${kubernetes:services.v1/event-listener}`)
If there is a more elegant workaround, we can give it a try, but for sure we
cannot remove the original property from the user configuration as we did
before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
