dmartinol commented on code in PR #367:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/367#discussion_r1474823710


##########
controllers/profiles/common/properties/discovery.go:
##########
@@ -99,6 +99,7 @@ func generateDiscoveryProperties(ctx context.Context, catalog 
discovery.ServiceC
                                        mpProperty := 
generateMicroprofileServiceCatalogProperty(plainUri)
                                        klog.V(log.I).Infof("Generating 
microprofile service catalog property %s=%s.", mpProperty, address)
                                        result.MustSet(mpProperty, address)
+                                       result.MustSet(k, 
"http://localhost:8080";)

Review Comment:
   I was wondering how I could create such discovery context, in fact. Our 
workflows are missing the 
`kogito-addons-quarkus-fabric8-kubernetes-service-catalog` extension, I'm not 
sure it can work w/o it.
   
   For instance, I've updated one of our application to define an openAPI 
endpoint as:
   ```
   mta_ui = ${kubernetes:services.v1/openshift-mta/mta-ui?port=ui}
   quarkus.rest-client.mta_json.url = ${mta_ui}/hub
   ```
   which is then mapped into the managed properties:
   ```
   mta_ui = http://localhost:8080
   
org.kie.kogito.addons.discovery.kubernetes\:services.v1\/openshift-mta\/mta-ui?port\=ui
 = http://mta-ui.openshift-mta.svc:8080
   ```
   Anyway it does not work, I believe it needs that particular extension to be 
resolved, correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to