tchughesiv commented on code in PR #372:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/372#discussion_r1478532326
##########
controllers/platform/services/services.go:
##########
@@ -358,14 +371,26 @@ func (j JobServiceHandler)
MergeContainerSpec(containerSpec *corev1.Container) (
return c, err
}
+// hasPostgreSQLConfigured returns true when either the SonataFlow Platform
PostgreSQL CR's structure or the one in the Job service specification is not nil
+func (j JobServiceHandler) hasPostgreSQLConfigured() bool {
+ return (j.platform.Spec.Services.JobService.Persistence != nil &&
j.platform.Spec.Services.JobService.Persistence.PostgreSQL != nil) ||
+ (j.platform.Spec.Persistence != nil &&
j.platform.Spec.Persistence.PostgreSQL != nil)
+}
Review Comment:
i wonder if this should be enhanced by adding `j.IsServiceSetInSpec` to the
check as well. like this?
```golang
return (j.IsServiceSetInSpec &&
j.platform.Spec.Services.DataIndex.Persistence != nil &&
j.platform.Spec.Services.DataIndex.Persistence.PostgreSQL != nil) ||
(j.platform.Spec.Persistence != nil &&
j.platform.Spec.Persistence.PostgreSQL != nil)
```
##########
controllers/platform/services/services.go:
##########
@@ -198,11 +198,24 @@ func (d DataIndexHandler) MergePodSpec(podSpec
corev1.PodSpec) (corev1.PodSpec,
return *c, err
}
+// hasPostgreSQLConfigured returns true when either the SonataFlow Platform
PostgreSQL CR's structure or the one in the Data Index service specification is
not nil
+func (d DataIndexHandler) hasPostgreSQLConfigured() bool {
+ return (d.platform.Spec.Services.DataIndex.Persistence != nil &&
d.platform.Spec.Services.DataIndex.Persistence.PostgreSQL != nil) ||
+ (d.platform.Spec.Persistence != nil &&
d.platform.Spec.Persistence.PostgreSQL != nil)
+}
Review Comment:
i wonder if this should be enhanced by adding `d.IsServiceSetInSpec` to the
check as well. like this?
```golang
return (d.IsServiceSetInSpec &&
d.platform.Spec.Services.DataIndex.Persistence != nil &&
d.platform.Spec.Services.DataIndex.Persistence.PostgreSQL != nil) ||
(d.platform.Spec.Persistence != nil &&
d.platform.Spec.Persistence.PostgreSQL != nil)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
