tchughesiv commented on code in PR #372:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/372#discussion_r1478887261
##########
controllers/platform/services/services.go:
##########
@@ -198,11 +198,24 @@ func (d DataIndexHandler) MergePodSpec(podSpec
corev1.PodSpec) (corev1.PodSpec,
return *c, err
}
+// hasPostgreSQLConfigured returns true when either the SonataFlow Platform
PostgreSQL CR's structure or the one in the Data Index service specification is
not nil
+func (d DataIndexHandler) hasPostgreSQLConfigured() bool {
+ return (d.platform.Spec.Services.DataIndex.Persistence != nil &&
d.platform.Spec.Services.DataIndex.Persistence.PostgreSQL != nil) ||
+ (d.platform.Spec.Persistence != nil &&
d.platform.Spec.Persistence.PostgreSQL != nil)
+}
Review Comment:
my suggestion is more about avoiding a null pointer exception. how can you
check if `d.platform.Spec.Services.DataIndex.Persistence != nil` when
`d.platform.Spec.Services.DataIndex == nil`?
for the same reason you're already checking
`d.platform.Spec.Services.DataIndex.Persistence` before you check
`d.platform.Spec.Services.DataIndex.Persistence. PostgreSQL`
##########
controllers/platform/services/services.go:
##########
@@ -198,11 +198,24 @@ func (d DataIndexHandler) MergePodSpec(podSpec
corev1.PodSpec) (corev1.PodSpec,
return *c, err
}
+// hasPostgreSQLConfigured returns true when either the SonataFlow Platform
PostgreSQL CR's structure or the one in the Data Index service specification is
not nil
+func (d DataIndexHandler) hasPostgreSQLConfigured() bool {
+ return (d.platform.Spec.Services.DataIndex.Persistence != nil &&
d.platform.Spec.Services.DataIndex.Persistence.PostgreSQL != nil) ||
+ (d.platform.Spec.Persistence != nil &&
d.platform.Spec.Persistence.PostgreSQL != nil)
+}
Review Comment:
my suggestion is more about avoiding a null pointer exception. how can you
check if `d.platform.Spec.Services.DataIndex.Persistence != nil` when
`d.platform.Spec.Services.DataIndex == nil`?
for the same reason you're already checking
`d.platform.Spec.Services.DataIndex.Persistence` before you check
`d.platform.Spec.Services.DataIndex.Persistence.PostgreSQL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
